Add advisory for xml-rs: unbounded entity expansion (Billion Laughs)#2661
Closed
BrianMcWilliams wants to merge 1 commit intorustsec:mainfrom
Closed
Add advisory for xml-rs: unbounded entity expansion (Billion Laughs)#2661BrianMcWilliams wants to merge 1 commit intorustsec:mainfrom
BrianMcWilliams wants to merge 1 commit intorustsec:mainfrom
Conversation
Member
|
@kornelski any thoughts on this advisory? |
|
The linked issue is titled "Profile-Guided Optimization (PGO) results" and doesn't seem to have anything to do with this advisory |
Contributor
|
xml-rs has protection against this attack. The report by @BrianMcWilliams is an LLM hallucinated spam. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisory for xml-rs: Unbounded Entity Expansion (Billion Laughs / XML Bomb, CWE-776)
xml-rs expands DTD entity references recursively with no depth or size limit. A sub-1KB payload can cause exponential memory consumption (~3M amplification ratio).
No patch exists. Alternative: quick-xml (does not expand entities by default).